Skip to content

Middleware runs according to path not router #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2016
Merged

Middleware runs according to path not router #580

merged 2 commits into from
Feb 17, 2016

Conversation

tunniclm
Copy link
Contributor

This pr attempts to document this issue: expressjs/express#2760

Feedback very welcome!

cc: @crandmck

tunniclm
tunniclm reviewed Feb 15, 2016
View reviewed changes
_includes/api/en/4x/router-use.md

app.use('/users', authRouter);
app.use('/users', openRouter);
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot to convert this code block to the right format.

crandmck pushed a commit that referenced this pull request Feb 17, 2016
Merge pull request #580 from tunniclm/note_on_router_middleware
9ff17ec 
Middleware runs according to path not router
@crandmck crandmck merged commit 9ff17ec into expressjs:gh-pages Feb 17, 2016
@crandmck crandmck removed the #review label Feb 17, 2016
@crandmck
Copy link
Member

Thanks for the clarification. It's usually easier for me if you can branch and then open a PR from the branch so I can make edits there and then merge the final form. For now, I'll merge and then edit in gh-pages... unless there is better workflow that I don't know about (entirely possible since I'm no Git expert).

@crandmck crandmck mentioned this pull request Feb 17, 2016
Closed
@tunniclm
Copy link
Contributor Author

@crandmck There was a branch on my repo (tunniclm:note_on_router_middleware) and I opened the PR from that branch. Was there something else I was missing?

@crandmck
Copy link
Member

I think tunniclm:note_on_router_middleware is a fork, not a branch. I just need to be able to edit the files on that branch, before merging the PR, which I can't do with that. I guess you need to have collaborator rights to create a new branch....? Perhaps I could clone that branch on https://github.com/tunniclm/expressjs.com. I think I just need to understand the required workflow.

@hacksparrow
Copy link
Member

@tunniclm how @crandmck and I have been working is, we create a branch on this repo, and collaborate on edits till the content on the branch is ready to be merged. His technical writing experience helps to give the professional touch we need in the docs.

Sian and Mike will need write access to be able to follow the workflow we've been following.

@crandmck
Copy link
Member

Is there any reaoson why @tunniclm and @sjanuary shouldn't have commit access to this repo?

@dougwilson dougwilson mentioned this pull request Feb 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tunniclm @crandmck @hacksparrow